Log an error if update() call returns ERROR
#1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
destogl,
harderthan,
LukasMacha97,
mhubii,
peterdavidfagan,
Raivias and
saikishor
christophfroehlich
changed the title
ERROR
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## humble #1969 +/- ##
==========================================
- Coverage 62.87% 62.84% -0.03%
==========================================
Files 109 109
Lines 12589 12590 +1
Branches 8549 8550 +1
==========================================
- Hits 7915 7912 -3
- Misses 858 861 +3
- Partials 3816 3817 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
saikishor
requested changes
Dec 21, 2024
|
@christophfroehlich like you. I'm also not sure which is the best option for this. Logging every time might spam a bit, and with throttle might miss some logs. Once might not be a good one here. |
christophfroehlich
force-pushed
the
warn_controller_error
branch
from
0430bd4 to
75aed5b
Compare
Ah you are right. I changed it to RCLCPP_ERROR. This will influence the update rate maybe, but this is not a operating mode which should be maintained right? |
bmagyar
approved these changes
Dec 23, 2024
saikishor
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed in #1873: On humble we do not take any action if the update call of a controller returns ERROR. As we don't want to break the behavior on humble, I suggest adding at least a log output.
I'm just not sure if we should just print it once, throttled, or on every call.
Closes #1873